Handle research trigger 'craft-item' #327
Merged
+47
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking for the Space Age changes of #320, I noticed 'new' errors when loading a project. Which was triggered by the (lack of) support of the new research triggers.
Adding the
craft-item
type was fairly easy (I was fiddling a bit and it worked):<removed outdated screenshot, see comments for newer one>
So I cleaned the code a little and made this PR.
Note that supporting
mine-entity
was also easy, but for some reason it makes most of the items inaccessible... So I did not include it in this PR. We need to take a better look.The other types, I did not try as their implementation was not directly apparent to me (and
craft-fluid
is not in use, so I could not try/test)